Update a pull request

Owned by Stefan Siegl
Last updated: Aug 27, 2015

It will happen that your pull request is rejected by an Integration Manager. We have very high Quality standards and it is the job of the integration manager to ensure this. Don't worry, rejected pull requests is a vital part of our Development Process.

How to update

GitHub provides a great and easy functionality to update your pull requests. Basically you only need to update the branch that you created the pull request from and the pull request is updated automatically.

Usually the Integration Manager asked you to change sth in your commit(s). An easy way is to make your changes and amend your last commit:

# take all changes that you made so far, stage them and add them to the last commit. 
# Important: This expects that your git HEAD is currently pointing to the commit of your pull request
git add *
git commit --amend

Afterwards you simply push to the remote branch that you base the pull request on

# take all changes that you made so far, stage them and add them to the last commit. 
# Important: This expects that your git HEAD is currently pointing to the commit of your pull request
git push YOUR_REMOTE [your-local-branch]:[your-remote-branch]

 

For the process to work you now need to:

  • Remove the rejected label from your pull request (The Integration Manager sets this label if he thinks that this pull request cannot be integrated)
  • Potentially update your JIRA ticket and put it back to "integration needed"