Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

The integration manager checks a pull request that a contributor created. If the pull request is valid, he pushes allows the commit to the stable repository of inspectIT. 

...

be integrated into the master branch through the GitHub UI.



Info

In the past, it was necessary to push manually against the master branch due to rebase being not available in the GitHub UI. This is not true anymore and it is mandatory now to use the official GitHub rebase & merge action (and through reviewable) so that the pull request will be automatically identified as being integrated.



The Integration Manager is responsible for:

...

For easier collaboration, several labels are defined on the GitHub, so that proper state of the Pull Request can be marked:

In-ProgressShould be set by integration manager when the integration starts.
RejectedShould be set by integration manager when integration failed
.Rebased & MergedShould be set by integration manager when pull request is closed with successful merging
.
Comments only in ReviewableShould be set always if the pull request is coming from a NovaTec colleague or student, if it's not there it's responsibility of integration manager to add it before using Reviewable.

 

 

 Old labels 

Rebased & MergedShould be set by integration manager when pull request is closed with successful merging.
Not needed anymore because GitHub (and Reviewable) now officially supports rebase & merge through the web UI.