...
The integration manager checks a pull request that a contributor created. If the pull request is valid, he pushes the commit to the stable repository of inspectIT.
| Warning |
|---|
Don't use the merge option on the GitHub to merge the ticket! Re-base and push manually only. Get the pull request locally by "git fetch origin pull/ID/head:BRANCHNAME" |
The Integration Manager is responsible for:
- ensure that the feature is working
- ensure that all tests are green
- ensure that no errors are reported in static code analysis (run the ant task of Agent, CMR and inspectIT, each with the option "clean release-and-analyse")
- ensure that the commit is correct (naming, squashing, ...)
ensure that the commit can be re-based on master
- check if the realization of the feature complies with other similar realizations
- ensure that new dependencies that are added are necessary and not already addressed by current libraries
- ensure that when adding new dependencies (or updating existing ones), the licensing information (Used licenses in inspectIT) is updated and the new license is checked (see Which licenses we can use and under what conditions/wiki/spaces/ARCHIVE/pages/9109545)
Marking Pull Requests with labels
...