Exception to the exclude rule

Description

We need a possibility to add the exception to one exclude rule in the CI. This would be useful for the user, but is also very needed for the remote tracing in order to support the UrlConnection instrumentation. Currently we have the exclude rule:

but all the implementations of the UrlConnection are actually sun classes. For example:

  • sun.net.www.protocol.http.HttpURLConnection

  • sun.net.www.protocol.https.HttpsURLConnectionImpl

  • etc

So I would like to keep the exclude rule sun.*, but add one or more exceptions like above.

Environment

None

Activity

Show:
Patrice Bouillet
December 2, 2016, 7:17 AM

Honestly, I don't like this approach at all. The excludes where up until now always true, no matter what. Now we have default configurations, overwritten by exclude rules, overwritten by exceptions to the exclude rules. Why not just define a better exclude rule to the sun subpackages which we really care about? I mean we did the sun.* definition because we didn't use any of these classes in the past. If we do now, we just need to exclude on a finer level. Let's discuss this please.

Patrice Bouillet
December 2, 2016, 9:25 AM

As discussed, the additional complexity could be hard to handle for the user and thus we want to keep it simple and redefine the exclude rules to match our needs.

Assignee

Ivan Senic

Reporter

Ivan Senic

Labels

None

Integrator

Patrice Bouillet

Components

Sprint

None

Fix versions

Priority

Medium
Configure