Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Refactoring tests for alerting component

Description

EMailSenderTest: Make protected methods private and test them trough the public methods.

Check if any other test introduced in the alerting ticket needs updating. Make sure that we have good code coverage there.

Environment

None

Gliffy Diagrams

Activity

Show:

Technical UserNovember 22, 2016 at 4:14 PM

SUCCESS: Integrated in

inspectIT - Integration #221
INSPECTIT-2232: Refactor alerting tests were needed (ivan.senic: 9c889ad3183c8a975dfe8a9dc7af0c014b9c4341)

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/AlertingStateLifecycleManagerTest.java

  • (delete) inspectit.server/src/test/java/rocks/inspectit/server/alerting/AlertTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/action/AlertingActionService.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/util/AlertingUtilsTest.java

  • (delete) inspectit.server/src/test/java/rocks/inspectit/server/mail/impl/EMailSenderTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/AlertingStateLifecycleManager.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/action/impl/EmailAlertAction.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/influx/util/InfluxQueryFactoryTest.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/AlertingSchedulerTest.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/action/AlertingActionServiceTest.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/ThresholdCheckerTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/AlertingScheduler.java

  • (edit) inspectit.shared.cs/src/test/java/rocks/inspectit/shared/cs/ci/AlertingDefinitionTest.java

  • (add) inspectit.server/src/main/java/rocks/inspectit/server/template/EMailTemplateResolver.java

  • (delete) inspectit.server/src/main/java/rocks/inspectit/server/mail/impl/EMailSender.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/AlertRegistry.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/AlertRegistryTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/util/AlertingUtils.java

  • (delete) inspectit.server/src/main/java/rocks/inspectit/server/mail/IEMailSender.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/action/impl/EmailAlertActionTest.java

  • (add) inspectit.server/src/main/java/rocks/inspectit/server/mail/EMailSender.java

  • (add) inspectit.server/src/test/java/rocks/inspectit/server/template/EMailTemplateResolverTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/influx/util/InfluxQueryFactory.java

  • (add) inspectit.server/src/test/java/rocks/inspectit/server/mail/EMailSenderTest.java

  • (add) inspectit.shared.cs/src/test/java/rocks/inspectit/shared/cs/communication/data/cmr/AlertTest.java

Ivan SenicNovember 21, 2016 at 4:39 PM

Some improvements still needed..

Marius OehlerOctober 25, 2016 at 1:27 PM

Yes, this can be a small task which maybe I can do.

Ivan SenicOctober 25, 2016 at 11:59 AM

As we decided to officially release the 1.7.4 at the sprint end, let's include this ticket by then, so that we finalize the alerting for now and don't leave any tails behind.

: This can be one of the small tasks we talked about?

Fixed

Details

Assignee

Reporter

Integrator

Sprint

Fix versions

Priority

Created October 24, 2016 at 2:49 PM
Updated November 22, 2016 at 5:57 PM
Resolved November 22, 2016 at 5:57 PM