Refactoring tests for alerting component

Description

EMailSenderTest: Make protected methods private and test them trough the public methods.

Check if any other test introduced in the alerting ticket needs updating. Make sure that we have good code coverage there.

Environment

None

Activity

Show:
Technical User
November 22, 2016, 4:14 PM

SUCCESS: Integrated in

inspectIT - Integration #221
INSPECTIT-2232: Refactor alerting tests were needed (ivan.senic: 9c889ad3183c8a975dfe8a9dc7af0c014b9c4341)

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/AlertingStateLifecycleManagerTest.java

  • (delete) inspectit.server/src/test/java/rocks/inspectit/server/alerting/AlertTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/action/AlertingActionService.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/util/AlertingUtilsTest.java

  • (delete) inspectit.server/src/test/java/rocks/inspectit/server/mail/impl/EMailSenderTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/AlertingStateLifecycleManager.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/action/impl/EmailAlertAction.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/influx/util/InfluxQueryFactoryTest.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/AlertingSchedulerTest.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/action/AlertingActionServiceTest.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/ThresholdCheckerTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/AlertingScheduler.java

  • (edit) inspectit.shared.cs/src/test/java/rocks/inspectit/shared/cs/ci/AlertingDefinitionTest.java

  • (add) inspectit.server/src/main/java/rocks/inspectit/server/template/EMailTemplateResolver.java

  • (delete) inspectit.server/src/main/java/rocks/inspectit/server/mail/impl/EMailSender.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/AlertRegistry.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/AlertRegistryTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/alerting/util/AlertingUtils.java

  • (delete) inspectit.server/src/main/java/rocks/inspectit/server/mail/IEMailSender.java

  • (edit) inspectit.server/src/test/java/rocks/inspectit/server/alerting/action/impl/EmailAlertActionTest.java

  • (add) inspectit.server/src/main/java/rocks/inspectit/server/mail/EMailSender.java

  • (add) inspectit.server/src/test/java/rocks/inspectit/server/template/EMailTemplateResolverTest.java

  • (edit) inspectit.server/src/main/java/rocks/inspectit/server/influx/util/InfluxQueryFactory.java

  • (add) inspectit.server/src/test/java/rocks/inspectit/server/mail/EMailSenderTest.java

  • (add) inspectit.shared.cs/src/test/java/rocks/inspectit/shared/cs/communication/data/cmr/AlertTest.java

Ivan Senic
November 21, 2016, 4:39 PM

Some improvements still needed..

Marius Oehler
October 25, 2016, 1:27 PM

Yes, this can be a small task which maybe I can do.

Ivan Senic
October 25, 2016, 11:59 AM

As we decided to officially release the 1.7.4 at the sprint end, let's include this ticket by then, so that we finalize the alerting for now and don't leave any tails behind.

: This can be one of the small tasks we talked about?

Fixed

Assignee

Marius Oehler

Reporter

Alexander Wert

Integrator

Ivan Senic