Intercept MiniLog messages and forward them to the slf4j

Description

Migrated from NovaTec Jira. Original ticket: INSPECTIT-1185

Currently kryo and kryonet use the MiniLog library to print out their messages.. These messages are not in any way printed into our logs.. We should make an interceptor for the messages and delegate them to the slf4j. It should not be too hard, only problem can be making the correct levels logging work.

Environment

None

Activity

Show:
Stefan Siegl
July 16, 2015, 2:30 PM

2015-03-05T11:16:31.000+0100 by Ivan Senic

Peace of cake:

As you can see everything is logged under com.esotericsoftware.minlog. There are two main questions:

  1. Should we enable such a bridge also on the Agent? This would mean that if application uses minlog their message would also be bridged? Not sure here

  2. What should be the default level there? So basically we need to set default levels for both minlog and slf4j with com.esotericsoftware.minlog logger. Now for minlog I think info is more that OK, we don't need any debug/trace messages.. In the slf4j it either warn or info.. I opt for warn messages only, since with info we get such simple messages like:

Can you advise quickly please?

Stefan Siegl
July 16, 2015, 2:30 PM

2015-07-06T12:38:03.000+0200 by Ivan Senic

Can you please read my comment on Jira regarding the Agent please.

Stefan Siegl
July 16, 2015, 2:30 PM

2015-02-25T08:28:18.000+0100 by Stefan Siegl

This is quite important as we do not see any problem that is related to sending problems.

Ivan Senic
July 20, 2015, 9:49 AM
Technical User
August 14, 2015, 5:43 AM

SUCCESS: Integrated in

inspectIT - Integration #55
INSPECTIT-1939: Bridge for minlog to slf4j (patrice.bouillet: 2de99b5010186c98696afbd50bb3097a34ee552a)

  • CMR/src/info/novatec/inspectit/cmr/CMR.java

  • Commons/src/info/novatec/inspectit/minlog/MinlogToSLF4JLogger.java

  • inspectIT/logging-config.xml

  • Agent/src/info/novatec/inspectit/agent/logback/LogInitializer.java

  • CMR/logging-config.xml

  • Agent/logging-config.xml

  • Commons/META-INF/MANIFEST.MF

  • inspectIT/src/info/novatec/inspectit/rcp/InspectIT.java

Fixed

Assignee

Ivan Senic

Reporter

Stefan Siegl

Labels

None

Integrator

Patrice Bouillet

Components

Sprint

None

Fix versions

Priority

Low